Skip to content

Fetch git tags when checking out repository in actions#953

Merged
thehrh merged 1 commit into
masterfrom
fix/fetch_git_tags_in_actions_checkout
Jun 12, 2026
Merged

Fetch git tags when checking out repository in actions#953
thehrh merged 1 commit into
masterfrom
fix/fetch_git_tags_in_actions_checkout

Conversation

@thehrh

@thehrh thehrh commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Versioneer looks for tags that are ancestors of the current commit, but can't find any when actions/checkout is not configured with fetch-tags: true. One can see the result in the html docs ("PISA 0+untagged.1.g53a4132 documentation"), for example, but also in the log output of every workflow that has installed PISA.

Now always fetch tags in workflows so that versioneer can always create the PISA version tag.

Note that, ironically, this PR itself can't demonstrate the fix working (checks still have untagged PISA), but all future workflow runs in master will have properly tagged versions.

@thehrh thehrh added this to the 4.3 milestone Jun 10, 2026
@thehrh thehrh requested a review from JanWeldert June 12, 2026 14:36
@thehrh thehrh merged commit 450871b into master Jun 12, 2026
2 checks passed
@thehrh thehrh deleted the fix/fetch_git_tags_in_actions_checkout branch June 13, 2026 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants